feat: add --server flag and set local AI service timeout #1042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CLI flag to switch between local/prod AI service without env vars. Set 5 min timeout for local to prevent hanging on issues.
| action="store_true", | ||
| help="(Deprecated) Async function optimization is now enabled by default. This flag is ignored.", | ||
| ) | ||
| parser.add_argument( |
Contributor
There was a problem hiding this comment.
why this over the env var method?
Contributor
There was a problem hiding this comment.
we don't really want to make this part of the user interface for codeflash cli
Collaborator
Author
There was a problem hiding this comment.
A/B testing, i want the flexibility so that I don't have to touch my env vars
| from codeflash.code_utils.github_utils import require_github_app_or_exit | ||
|
|
||
| if args.server: | ||
| os.environ["CODEFLASH_AIS_SERVER"] = args.server |
Contributor
There was a problem hiding this comment.
this can go wrong because there is no validation of user input to be only prod/local
Collaborator
Author
There was a problem hiding this comment.
it's meant to be for internal use only so I think we'll be ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--serverCLI flag to switch between local/prod AI serviceUsage
codeflash --file foo.py --server local codeflash --file foo.py --server prod