⚡️ Speed up function find_last_node by 19,842%
#242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 19,842% (198.42x) speedup for
find_last_nodeinsrc/algorithms/graph.py⏱️ Runtime :
66.7 milliseconds→334 microseconds(best of250runs)📝 Explanation and details
The optimized code achieves a ~200x speedup by eliminating redundant nested iterations through a fundamental algorithmic improvement.
What changed:
The original implementation uses a nested loop structure where for each node, it checks against all edges to verify the node isn't a source (
all(e["source"] != n["id"] for e in edges)). This creates O(N×M) time complexity where N is the number of nodes and M is the number of edges.The optimized version pre-computes a set of all source node IDs (
sources = {e["source"] for e in edges}), then performs simple O(1) membership checks (n["id"] not in sources). This reduces complexity to O(N+M).Why it's faster:
Performance characteristics from tests:
The optimization is universally beneficial for any workflow calling this function with non-trivial graph sizes, particularly in scenarios involving graph traversal, flow analysis, or dependency resolution where graphs commonly have hundreds or thousands of nodes.
✅ Correctness verification report:
🌀 Click to see Generated Regression Tests
To edit these changes
git checkout codeflash/optimize-find_last_node-mk3jbk03and push.