add basic search functionality to the Backlog plugin #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a search command to the bot that will return the last 10 lines matching the provided string in the specified context. This required sending the bouncer to the bot instead of the just the user, since we needed to get more state. Stuff to be done to make better: * Let users page through results * Let users ask for X lines of context around one of the results * Make searching more efficient (we normally want to search from the end of a backlog) * Colorize results The first two items will require keeping some state around for searches (things like last query, offsets of each result into the file, etc.)
Author
There was a problem hiding this comment.
Oops - security hole here. filename is built from the user-specified ctx which is not sanitized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a search command to the bot that will return the last 10 lines matching
the provided string in the specified context.
This required sending the bouncer to the bot instead of the just the user,
since we needed to get more state.
Stuff to be done to make better:
backlog)
The first two items will require keeping some state around for searches
(things like last query, offsets of each result into the file, etc.)