Fix SpotBugs naming convention violations #4408

shai-almog · 2026-01-13T02:50:12Z

Motivation

Eliminate SpotBugs NM_FIELD_NAMING_CONVENTION and NM_METHOD_NAMING_CONVENTION findings reported for internal fields and helper methods.
Keep code behavior and public API semantics unchanged while addressing naming warnings.
Ensure the CI quality report treats naming-convention violations as build failures so regressions are caught early.

Description

Renamed internal coefficient fields in GeneralPath curve helpers to lower-case identifiers (e.g. in QuadCurve and CubicCurve: Ax/Ay/Bx/By/Cx/Cy/Ax3/Bx2 -> axCoeff/ayCoeff/bxCoeff/byCoeff/cxCoeff/cyCoeff/axCoeff3/bxCoeff2) and updated all usages accordingly.
Standardized helper/method names to lower-case: AnalyticsService.GetGARequest() -> AnalyticsService.getGaRequest() and ColorUtil.ToARGB(...) -> ColorUtil.toArgb(...).
Fixed GridBagLayout naming by replacing ArrangeGrid/AdjustForGravity usages with arrangeGrid/adjustForGravity and removed accidental self-referencing stubs introduced during renames.
Updated the quality-gate script .github/scripts/generate-quality-report.py to treat NM_FIELD_NAMING_CONVENTION and NM_METHOD_NAMING_CONVENTION as forbidden SpotBugs rules so they fail the build.

Testing

No automated tests were executed as part of this change.
Changes are limited to identifier renames and internal call sites to preserve original semantics.
The CI quality gate will now fail on the two SpotBugs naming rules added to the forbidden list.
Manual compilation / CI run is recommended to validate SpotBugs/PMD/Checkstyle results in the updated pipeline.

Codex Task

github-actions · 2026-01-13T02:56:59Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2282 total, 0 failed, 0 skipped
📊 Line coverage: 52.88% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.io.rest.RequestBuilder$FetchAsPropertyListActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$FetchAsPropertiesActionListener – 0.00%
  - com.codename1.ui.Display$EdtException – 0.00%
  - com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
  - com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsStringAsyncImplActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsJsonMapActionListener – 0.00%
  - com.codename1.payment.Purchase$SynchronizeReceiptsSyncRunnable – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsBytesAsyncImplActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$FetchAsJsonMapActionListener – 0.00%

Static Analysis

❌ SpotBugs: 106 findings (Normal: 71, Low: 35) [HTML preview] [Download]
- Top findings
  - Normal: CodenameOne/src/com/codename1/capture/Capture.java:262 – Naked notify in com.codename1.capture.Capture$CallBack.actionPerformed(ActionEvent) (rule: NN_NAKED_NOTIFY)
  - Normal: CodenameOne/src/com/codename1/charts/ChartComponent.java:682 – Return value of com.codename1.charts.renderers.XYMultipleSeriesRenderer.isPanEnabled() ignored, but method has no side effect (rule: RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT)
  - Normal: CodenameOne/src/com/codename1/charts/ChartComponent.java:770 – Return value of com.codename1.charts.renderers.XYMultipleSeriesRenderer.isZoomEnabled() ignored, but method has no side effect (rule: RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT)
  - Normal: CodenameOne/src/com/codename1/charts/compat/Paint.java:38 – Unused field: com.codename1.charts.compat.Paint.g (rule: UUF_UNUSED_FIELD)
  - Normal: CodenameOne/src/com/codename1/charts/views/BarChart.java:383 – Unused field: com.codename1.charts.views.BarChart$Point.seriesIndex (rule: UUF_UNUSED_FIELD)
  - …and 101 more
❌ PMD: 2555 findings (P2: 1, P3: 486, P4: 2068) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/ui/Display.java:1040 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
  - P3: CodenameOne/src/com/codename1/charts/views/LineChart.java:208 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/components/RSSReader.java:500 – Overriding method merely calls super (rule: UselessOverridingMethod)
  - P3: CodenameOne/src/com/codename1/facebook/Album.java:198 – Overriding method merely calls super (rule: UselessOverridingMethod)
  - P3: CodenameOne/src/com/codename1/facebook/FaceBookAccess.java:1312 – Unnecessary semicolon (rule: UnnecessarySemicolon)
  - …and 2550 more
❌ Checkstyle: 220847 findings (Warning: 220847) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 220842 more

Generated automatically by the PR CI workflow.

shai-almog · 2026-01-13T03:03:05Z

Compared 30 screenshots: 30 matched.

Native Android coverage

📊 Line coverage: 24.85% (2663/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.46% (12361/50528), branch 15.33% (716/4672), complexity 17.52% (743/4241), method 33.08% (602/1820), class 34.98% (106/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 24.85% (2663/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.46% (12361/50528), branch 15.33% (716/4672), complexity 17.52% (743/4241), method 33.08% (602/1820), class 34.98% (106/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

shai-almog · 2026-01-13T03:19:08Z

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.
graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.
graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.
kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

VM Translation Time: 351 seconds
Compilation Time: 82 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	34450 ms
Extract Extensions	28 ms
Google Services Setup	3 ms
Scan Classes	934 ms
Extract Libs	1410 ms
Inject Build Hints	121 ms
Generate Unit Tests	25 ms
Generate Stubs	2599 ms
Compile Stubs	2853 ms
Generate Icons	1321 ms
Prepare ParparVM	236 ms
ParparVM Execution	187347 ms
Post-VM Setup	134 ms
CocoaPods	5450 ms
Finalize	29 ms
Total Time	236941 msMaven Overhead : 115000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot (Run)	67000 ms
App Install	16000 ms
App Launch	15000 ms
Test Execution	173000 ms

Fix SpotBugs naming issues

9ad8a02

shai-almog added the codex label Jan 13, 2026 — with ChatGPT Codex Connector

shai-almog merged commit 2c6e5a1 into master Jan 13, 2026
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix SpotBugs naming convention violations #4408

Fix SpotBugs naming convention violations #4408

shai-almog commented Jan 13, 2026

Uh oh!

github-actions bot commented Jan 13, 2026

Uh oh!

shai-almog commented Jan 13, 2026 •

edited

Loading

Uh oh!

shai-almog commented Jan 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix SpotBugs naming convention violations #4408

Fix SpotBugs naming convention violations #4408

Conversation

shai-almog commented Jan 13, 2026

Motivation

Description

Testing

Uh oh!

github-actions bot commented Jan 13, 2026

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Uh oh!

shai-almog commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Benchmark Results

Detailed Performance Metrics

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shai-almog commented Jan 13, 2026 •

edited

Loading

shai-almog commented Jan 13, 2026 •

edited

Loading