Fix qmdiEditor: cannot hide preview #146 #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborator
|
https://github.com/diegoiast/qtedit4/actions/runs/20267671314 it works on this build, so no problem. Nice! The windows build will get fixed tonight. It was one of the errors I introduced while working on flatpack. I have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Even though the preview was toggled off, the preview gets enabled once the user starts typing. Everytime the text is modified, updateClientName() function is called, which only considers if the current file has preview and default autoPreview which is always True.
Solution: We still need updateClientName() call when the text is changed but just the preview has to retain previous state. Since autoPreview is only used at openFile for particular client (only relevant at that point), update it with current state of preview and then update client name
If we have to do it differently, We need to separate preview settings from updateClientName