Skip to content

Conversation

@codfish
Copy link
Owner

@codfish codfish commented Sep 22, 2025

This PR updates how the additional-packages input is handled so the action no longer fails based on the package manager your app uses. Instead of installing additional packages into the working directory (/github/workspace), they are now installed in the script directory.

This approach works because semantic will resolve plugins from both locations.

Previously, installing into the working directory meant we were interfering with the app’s package manager, which caused errors like:

image image

@thomasv314

Copilot AI review requested due to automatic review settings September 22, 2025 19:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for multiple package managers (npm, yarn, pnpm) by detecting which one to use based on lockfile presence in the working directory. The implementation automatically selects the appropriate package manager and uses the correct installation commands for each.

  • Adds package manager detection logic based on lockfile presence
  • Updates package installation to use detected package manager with appropriate flags
  • Installs pnpm globally in the Docker container to support all three package managers

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
entrypoint.js Implements package manager detection and updates installation logic to support npm, yarn, and pnpm
Dockerfile Adds global pnpm installation to support pnpm package manager

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codfish codfish force-pushed the pnpm branch 2 times, most recently from d8ae1a9 to 869158f Compare September 22, 2025 20:03
Copilot AI review requested due to automatic review settings September 22, 2025 20:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codfish codfish force-pushed the pnpm branch 2 times, most recently from 74a1390 to a5ea6ff Compare September 22, 2025 21:33
Copilot AI review requested due to automatic review settings September 22, 2025 21:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codfish codfish changed the title feat: add support for other package managers feat: add support for pnpm Sep 22, 2025
@codfish codfish force-pushed the pnpm branch 2 times, most recently from cb4e75f to 459110c Compare September 22, 2025 22:46
Copilot AI review requested due to automatic review settings September 22, 2025 22:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codfish codfish force-pushed the pnpm branch 2 times, most recently from c1d3a04 to 1c5b5c6 Compare September 23, 2025 01:14
Copilot AI review requested due to automatic review settings September 23, 2025 01:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings September 23, 2025 02:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings September 23, 2025 02:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings September 23, 2025 02:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

entrypoint.js:1

  • This large block of commented code should be removed. If this functionality is needed, it should be implemented properly rather than left as commented code.
import * as childProcess from 'child_process';

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings September 23, 2025 19:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings September 23, 2025 19:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings September 23, 2025 20:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings September 23, 2025 21:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codfish codfish marked this pull request as ready for review September 23, 2025 21:51
@codfish codfish merged commit 6c65402 into main Sep 23, 2025
1 check passed
@codfish codfish deleted the pnpm branch September 23, 2025 22:22
@github-actions
Copy link

🎉 This PR is included in version 4.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants