Use base class distutils.cmd.Command if/when necessary
#89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatch
reviewed
Mar 20, 2025
| strategy: | ||
| matrix: | ||
| python-version: ['3.6', '3.7'] | ||
| python-version: ['3.7', '3.8', '3.9'] |
Member
There was a problem hiding this comment.
If there isn't CI running on 3.6 I'm reluctant to say setupmeta is compatible with it. Am I reading this right?
Collaborator
Author
There was a problem hiding this comment.
Tests pass with 3.6, but there is some unrelated failure on py3.6 venv creation currently on GH actions. setupmeta's is still py3.6 compatible, but it is getting harder to exercise py3.6 indeed (including locally, where you can't use tox-uv for exameple, must use tox v3)
Collaborator
Author
There was a problem hiding this comment.
Bumped python_requires to 3.7+. You're right, no point in trying to keep 3.6 around any longer.
thatch
approved these changes
Mar 20, 2025
thatch
reviewed
Mar 20, 2025
| skip_missing_interpreters = true | ||
|
|
||
| envlist = py{37,38,39,310,311,312,313}, coverage, docs, style, security | ||
| indexserver = |
Member
There was a problem hiding this comment.
maybe include a comment about why this apparent no-op is here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted
checkcommand redefinition for setuptools 77.0.3.See pypa/setuptools#4902