Skip to content

Fix parameters bug #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sosoxuc wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix parameters bug #200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bbfe36
Fix parameters bug
sosoxuc Sep 2, 2024
a2f9ac8
Merge branch 'master' into master
alex-stone Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion quickstart-template/trade-assets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ let wallet = await Wallet.create({ networkId: Coinbase.networks.BaseMainnet });
* Fund the Wallet's default Address with ETH from an external source.
* Trade 0.00001 ETH to USDC.
*/
let trade = await wallet.createTrade(0.00001, Coinbase.assets.Eth, Coinbase.assets.Usdc);
let trade = await wallet.createTrade({
amount: 0.00001,
fromAssetId: Coinbase.assets.Eth,
toAssetId: Coinbase.assets.Usdc,
});

// Wait for the trade to complete or fail on-chain.
await trade.wait();
Expand Down