Skip to content

Conversation

@0xRAG
Copy link
Contributor

@0xRAG 0xRAG commented Jan 14, 2025

Added

  • Add skipBatching option to Wallet.createTransfer to allow for lower latency gasless transfers.

@cb-heimdall
Copy link

cb-heimdall commented Jan 14, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

* @param options.assetId - The ID of the Asset to send.
* @param options.destination - The destination of the transfer. If a Wallet, sends to the Wallet's default address. If a String, interprets it as the address ID.
* @param options.gasless - Whether the Transfer should be gasless. Defaults to false.
* @param options.skipBatching - When true, the Transfer will be submitted immediately. Otherwise, the Transfer will be batched. Defaults to false. Note: requires gasless option to be set to true.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should frame this to be something like "to achieve a high throughput, enable batching"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Will add to the docs

@0xRAG 0xRAG merged commit 10a646a into master Jan 14, 2025
6 checks passed
@John-peterson-coinbase John-peterson-coinbase deleted the v0.14.0 branch January 14, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants