Skip to content

chore: set default list txn page size to 1 #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
xinyu-li-cb wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

chore: set default list txn page size to 1 #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45c26d4
chore: set default list txn page size to 1
xinyu-li-cb Jan 21, 2025
68bdf2e
fix test
xinyu-li-cb Jan 21, 2025
24c81ee
fix test
xinyu-li-cb Jan 21, 2025
ae93342
Merge branch 'master' of https://github.com/coinbase/coinbase-sdk-rub…
xinyu-li-cb Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/coinbase/constants.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ module Coinbase
DEFAULT_PAGE_LIMIT = 100

# The default page limit for transaction paginated API request.
DEFAULT_TRANSACTION_PAGE_LIMIT = 10
DEFAULT_TRANSACTION_PAGE_LIMIT = 1
end
4 changes: 2 additions & 2 deletions spec/support/shared_examples/address_transactions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
before do
allow(transaction_history_api)
.to receive(:list_address_transactions)
.with(normalized_network_id, address_id, { limit: 10, page: nil })
.with(normalized_network_id, address_id, { limit: 1, page: nil })
.and_return(response)
end

Expand All @@ -36,7 +36,7 @@
end

let(:api) { transaction_history_api }
let(:fetch_params) { ->(page) { [normalized_network_id, address_id, { limit: 10, page: page }] } }
let(:fetch_params) { ->(page) { [normalized_network_id, address_id, { limit: 1, page: page }] } }
let(:resource_list_klass) { Coinbase::Client::AddressTransactionList }
let(:item_klass) { Coinbase::Transaction }
let(:item_initialize_args) { nil }
Expand Down
Loading