feat: Add PHP 8.5 support #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds PHP 8.5 support to the project by updating dependencies, build configurations, and CI workflows. Key changes include updating PHP version constraints, modernizing the build infrastructure with valgrind as a git submodule, and refactoring GitHub Actions workflows to use a centralized workspace preparation step.
- Updates PHP version support from 8.0-8.4 to 7.4, 8.1-8.5
- Adds valgrind as a git submodule and updates Docker build process
- Refactors CI workflows to use a prepare step that creates workspace artifacts
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| third_party/valgrind | Adds valgrind as a git submodule |
| pskel.sh | Adds PHP 8.5 ext_skel vendor parameter support and fixes shell script issues |
| ext/php_colopl_bc.h | Bumps extension version to 12.0.0 |
| ext/colopl_bc_php74.c | Adds object comparison cases and fixes whitespace |
| composer.json | Updates PHP and dev dependency versions for PHP 8.5 |
| compose.yaml | Adds commented configuration examples |
| Dockerfile | Updates to PHP 8.5, adds valgrind build from submodule, upgrades to clang-21 |
| .gitmodules | Configures valgrind git submodule |
| .github/workflows/coverage.yaml | Refactors to use centralized workspace preparation |
| .github/workflows/ci_windows.yaml | Adds PHP 8.5 to test matrix and uses workspace artifacts |
| .github/workflows/ci_prepare.yaml | New workflow for preparing workspace artifacts |
| .github/workflows/ci_native_linux.yaml | Adds PHP 8.5 support and artifact-based workspace |
| .github/workflows/ci_macos.yaml | Updates runner images and adds PHP 8.5 |
| .github/workflows/ci_emulated_linux.yaml | Adds PHP 8.5 and SKIP_VALGRIND build arg |
| .github/workflows/ci.yaml | Adds prepare job and workflow concurrency control |
| .github/workflows/build.yaml | Removes entire build workflow file |
| .github/renovate.json | Adds Renovate configuration for dependency management |
| .github/octocov.yml | Removes octocov configuration |
| .github/dependabot.yml | Removes dependabot configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.