Update get_default_fill_value to be compatible with numpy >=2.0.0
#35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silent truncation no longer occurs in the numpy >=2.0.0
shunt16
approved these changes
Nov 20, 2024
Collaborator
shunt16
left a comment
shunt16
left a comment
There was a problem hiding this comment.
Fabulous @mattgoalen - thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silent truncation of values is no longer supported in the newest numpy versions (see NEP 50 ).
numpy.uint8(-1)has therefore been replaced withnumpy.iinfo(numpy.uint8).maxinget_default_fill_value, and further related modifications were made. The constraint onnetcdf4was there to constrain the numpy version to <2.0.0 and is therefore no longer required and has been removed.