Skip to content

Conversation

@Korilakkuma
Copy link

@Korilakkuma Korilakkuma commented Jun 21, 2020

This Pull Request will ...

This PR will use MediaElementAudioSourceNode instead of AudioBufferSourceNode because AudioBufferSourceNode should be used one-shot audio. However, if you think that use OfflineAudioContext in the future, this PR should be closed.

Why is this Pull Request needed ?

MediaElementAudioSourceNode should be used for playing the tune.

Resolves issues

N/A

Screenshot

urchin

mediaRecorder.start(100)
tempSrc.start(0)

animationId = requestAnimationFrame(render)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that requestAnimationFrame is not needed (Because of 60fps delay ...). Therefore, animation starts by invoking render.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant