Add a Conforma rule to check RPM origin for build deps of RPM builds #1578
+278
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* NOTE: This check is only a warning right now. It will be upgraded to deny once we are confident the rule and the data is correct and not blocking valid builds JIRA: ROK-814
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 16 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
Author
|
Tests Generated by Claude |
st3penta
reviewed
Nov 27, 2025
Comment on lines
63
to
74
| # Test with another invalid download location | ||
| test_invalid_download_location_wrong_domain if { | ||
| invalid_location := "https://malicious.org/package.rpm" | ||
| att := _sbom_attestation_with_download_location(invalid_location) | ||
| expected_locations := array.concat(["NOASSERTION"], _mock_allowed_locations) | ||
| expected := {{ | ||
| "code": "rpm_build_deps.download_location_valid", | ||
| "msg": sprintf("Download Location is %s which is not in %v", [invalid_location, expected_locations]), | ||
| }} | ||
| lib.assert_equal_results(expected, rpm_build_deps.warn) with input.attestations as [att] | ||
| with data.rule_data.allowed_rpm_build_dependency_sources as _mock_allowed_locations | ||
| } |
Contributor
There was a problem hiding this comment.
duplicate of test_invalid_download_location, can be removed
Comment on lines
76
to
84
| # Test with location that doesn't match the patterns | ||
| test_invalid_download_location_no_pattern_match if { | ||
| # This location doesn't match any of the allowed patterns | ||
| invalid_location := "https://example.com/package.rpm" | ||
| att := _sbom_attestation_with_download_location(invalid_location) | ||
| results := rpm_build_deps.warn with input.attestations as [att] | ||
| with data.rule_data.allowed_rpm_build_dependency_sources as _mock_allowed_locations | ||
| count(results) > 0 | ||
| } |
Contributor
There was a problem hiding this comment.
duplicate of test_invalid_download_location, can be removed
| # description: Builds have valid download locations for RPM build dependencies | ||
| # custom: | ||
| # short_name: download_location_valid | ||
| # failure_msg: Download Location is %s which is not in %v |
Contributor
There was a problem hiding this comment.
Suggested change
| # failure_msg: Download Location is %s which is not in %v | |
| # failure_msg: RPM build dependency source %s is not in the allowed list: %v. | |
| # solution: >- | |
| # The list of allowed RPM build dependency sources can be set via the | |
| # `allowed_rpm_build_dependency_sources` rule data. |
st3penta
approved these changes
Dec 9, 2025
Contributor
st3penta
left a comment
st3penta
left a comment
There was a problem hiding this comment.
lgtm. @conforma/devs can we merge it?
simonbaird
reviewed
Dec 16, 2025
| result := lib.result_helper(rego.metadata.chain(), [pkg.downloadLocation, valid_locations]) | ||
| } | ||
|
|
||
| matches_any(branch, valid_locations) if { |
Member
There was a problem hiding this comment.
Not a blocker, but I'd suggest making the params more generic. "Branch" seems confusing in this context.
Suggested change
| matches_any(branch, valid_locations) if { | |
| matches_any(value, patterns) if { |
And maybe we flip the order so it's consistent with regex.match:
Suggested change
| matches_any(branch, valid_locations) if { | |
| matches_any(patterns, value) if { |
simonbaird
reviewed
Dec 16, 2025
| some pkg in s.packages | ||
|
|
||
| # NOASSERTION is displayed in the SBOM for the RPMS that have been built | ||
| valid_locations := array.concat(["NOASSERTION"], lib.rule_data("allowed_rpm_build_dependency_sources")) |
Member
There was a problem hiding this comment.
Also not a blocker, but it might be tidier and perhaps more efficient to move the concat outside the rule. It's a pattern we follow elsewhere
warn ... {
...
not matches_any(pkg.downloadLocation, _valid_locations)
}
# NOASSERTION is displayed in the SBOM for the RPMS that have been built
_valid_locations := array.concat(["NOASSERTION"], lib.rule_data("allowed_rpm_build_dependency_sources"))
simonbaird
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deny once we are confident the rule and the data is correct and not
blocking valid builds
JIRA: ROK-814