add crosschain transfer contract #7
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakekidd
changed the title
rhlsthrm
suggested changes
Jun 16, 2021
contracts/crosschain/Crosschain.sol
Outdated
| } | ||
|
|
||
| struct TransferResolver { | ||
| bytes initiatorSignature; |
Contributor
There was a problem hiding this comment.
initiatorSignature needs to be part of the initial state, not the resolver.
contracts/crosschain/Crosschain.sol
Outdated
| ); | ||
|
|
||
| // Update state. | ||
| balance.amount[1] = balance.amount[0]; |
Contributor
There was a problem hiding this comment.
Create should not be changing anything in the state. This is a pure function that just returns a boolean, so any state changes aren't persisted anywhere.
contracts/crosschain/Crosschain.sol
Outdated
| "CrosschainTransfer: INVALID_PREIMAGE" | ||
| ); | ||
|
|
||
| // Reduce CrosschainTransfer amount by optional fee. |
Contributor
There was a problem hiding this comment.
"Reduce CrosschainTransfer amount by optional fee" -> "Reduce CrosschainTransfer amount to optional fee"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.