Refactor ImportCSVPopup to eliminate repetitive code patterns #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ImportCSVPopupclass contained significant code duplication across field initialization, UI creation, and event handlers.Changes
self.selected_*attributes with a singleself.selected_fieldsdictionary_create_field_layout()helper to generate field layouts from configuration tuples, replacing ~140 lines of duplicated widget creation code with a 12-item config listselect_*()methods with a single_generic_select_handler()that dispatches based on field namecollate_selections()now returnsself.selected_fields.copy()instead of manually reconstructing the dictionaryExample
Before:
After:
Net reduction: 314 → 235 lines (-25%)
Legacy
select_*()methods preserved as thin wrappers for backward compatibility.Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.