-
Notifications
You must be signed in to change notification settings - Fork 118
Refactor use statements to enable building Windows #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8c1e606 to
9449ca0
Compare
jprendes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working in this :-).
I think native windows support would add a lot of value.
I haven't finished, but here are my comments so far.
Also, I'm not a big fan of the new cfg_window / cgf_unix macros.
I think they add a lot of cyclomatic complexity to the code.
I would much prefer to create separate os-specific modules, and factor out the code that differs between each os.
dfbb016 to
e075b6c
Compare
8314219 to
47612bf
Compare
3199cd8 to
5c51fd0
Compare
|
latest failure was the outofspace we are seeing on other PRs: |
0ee6fe6 to
ea1e5e6
Compare
@jprendes I cleaned this up where it made sense. In some cases, I believe its easier to read if it is in-lined but let me know what you think. The one last place I would like to do this is around the mounting code but I don't know the abstraction to put in place just yet. I've started this on the Windows side but haven't full flushed it out but will follow up on moving it to an abstraction in the next PR. |
|
test failure is #252 |
cpuguy83
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jprendes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is looking great!
Looking forward to having this merged :-)
Mossaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
19a9846 to
a4fcd3e
Compare
Mossaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Signed-off-by: James Sturtevant <jstur@microsoft.com> Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
a4fcd3e to
42dc656
Compare
|
looks like a different issue with ubuntu 22.04, now that storage has been solved. |
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
42dc656 to
db027ae
Compare
|
Cool, shall I merge this in? @jsturtevant |
This PR does not enable windows features but it does make it so the shim will build on Windows. This will make the following PR's smaller and easier to digest to do it in steps. It also makes it easier while other changes go in without having to rebase complex changes.
one small step towards #49
For now this disables
dead-codeandunused importsbut should be turned on before in following PR's as functionality is added.Todo in the PR:
Add a CI