Use common library function for getting the module name #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsturtevant
force-pushed
the
use-args-check
branch
from
cde2bb0 to
a454079
Compare
Mossaka
previously approved these changes
Aug 16, 2023
Member
Mossaka
left a comment
Mossaka
left a comment
There was a problem hiding this comment.
LGTM! Left one minor comment.
| let (module_name, _method) = oci::get_module(spec); | ||
| let module_name = match module_name { | ||
| Some(m) => m, | ||
| None => return false, |
Member
There was a problem hiding this comment.
Could you please add a debug!() or info!() here for logging why can_handle returns a false?
Contributor
Author
There was a problem hiding this comment.
added info statement PTAL
Signed-off-by: James Sturtevant <jstur@microsoft.com>
Signed-off-by: James Sturtevant <jstur@microsoft.com>
jsturtevant
force-pushed
the
use-args-check
branch
from
a454079 to
0bf5eb1
Compare
Mossaka
approved these changes
Aug 16, 2023
Member
|
Ill merge once the CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick follow up to #219 and #156