Fixes #27651 - Fix health inspect/ps for rootfs containers with empty…

[jasonoh11]

… healthcheck

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

• Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
  commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
  the sign-off email address. See CONTRIBUTING.md
  for more information.
• Referenced issues using Fixes: #00000 in commit message (if applicable)
• Tests have been added/updated (or no tests are needed)
• Documentation has been updated (or no documentation changes are needed)
• All commits pass make validatepr (format/lint checks)
• Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

This fixes #27651, which raises the issue in which containers hold a stale "starting" status even though no healthchecks are configured.

As @mheon pointed out, the bug lies in the following condition:

if c.config.HealthCheckConfig != nil && (len(c.config.HealthCheckConfig.Test) != 1 || c.config.HealthCheckConfig.Test[0] != "NONE")

In the case of a non-nil HealthCheckConfig and a nil or empty HealthCheckConfig.Test, the condition incorrectly enters the code path that handles when a health check is actually configured.

These conditions seem to arise when building a container with --rootfs as opposed to building from an image.

I extended HasHealthCheck() to correctly evaluate the various combinations of HealthCheckConfig and HealthCheckConfig.Test, and used this function to replace repeated, incorrect code causing both podman inspect rootfs-test --format '{{json .State.Health}}' and podman ps to incorrectly return stale statuses.

I also included a unit test for HasHealthCheck

[Yarboa]

/packit test --identifier cockpit-revdeps

[packit-as-a-service]

Account Yarboa has no write access nor is author of PR!

[Yarboa]

/packit test --identifier cockpit-revdeps

@jasonoh11 please ask someone to rerun failed test as above
It seems like machine gets to error before tests start to run

[Honny1]

LGTM! I have just one small nit.

[jasonoh11]

Hi @Honny1 thanks for reviewing! I pushed an update according to your suggestion. It says there's still a workflow waiting for approval from a maintainer, is there any more action needed on my end or is this ready for approval?

Also, @Yarboa mentioned a failed test, does this need to be resolved?

Thanks!

[Honny1]

CI is not happy.

+ ./bin/golangci-lint run --build-tags=apparmor,seccomp,selinux
pkg/ps/ps.go:230:1: File is not properly formatted (gofumpt)

^
1 issues:
* gofumpt: 1

[jasonoh11]

I cleaned up the spacing, thanks!

[Honny1]

Some tests are flaky. I can re-run them for you.

[Honny1]

+ ./bin/golangci-lint run --build-tags=apparmor,seccomp,selinux
pkg/ps/ps.go:229:1: File is not properly formatted (gofumpt)
		
^
1 issues:
* gofumpt: 1

[jasonoh11]

Fixed, thanks

[packit-as-a-service]

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.