Skip to content

Conversation

@sebastiaanspeck
Copy link
Contributor

It has more images, but trivy is the most used AFAIK

It has more images, but trivy is the most used AFAIK

Signed-off-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@vrothberg
Copy link
Member

Ay, in order to pass the DCO check, the commit needs the famous Signed-off-by field. Can you add that and repush?

$ git commit -s --amend
$ git push -f <origin> <branch>

Signed-off-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
@vrothberg vrothberg merged commit da8920d into containers:main Aug 19, 2025
2 checks passed
@rhatdan
Copy link
Member

rhatdan commented Aug 19, 2025

One advantage of "aquasec/trivy" = "docker.io/aquasec/trivy" would be that in strict handling of shortnames, the name aquasec/trivy would still work.

@sebastiaanspeck sebastiaanspeck deleted the patch-1 branch August 19, 2025 15:28
@sebastiaanspeck
Copy link
Contributor Author

One advantage of "aquasec/trivy" = "docker.io/aquasec/trivy" would be that in strict handling of shortnames, the name aquasec/trivy would still work.

Please let me know if that is still the preferred way how we want this to be listed. At first I used the same format from Grafana, but @vrothberg commented: #69 (comment).

@rhatdan
Copy link
Member

rhatdan commented Aug 20, 2025

I was only suggesting if users tend to do podman run aquasec/trivy as well as podman run trivy we might want both shortnames added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants