Skip to content

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Dec 11, 2025

Description

When output is missing from tool result, add a placeholder output to prevent compaction for dangling tool calls.

resolves CON-5032

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

before.mp4
after.mp4

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Adds a fallback tool result message when a tool call has no output, preventing compaction of dangling tool calls and keeping CLI transcripts consistent. Resolves CON-5032.

  • Bug Fixes
    • In convertFromUnifiedHistory, emit a role: "tool" message with "Tool cancelled" when tool output is missing.
    • Prevents dropped tool calls and history compaction when a tool is cancelled or returns no output.

Written for commit 0792b94. Summary will update automatically on new commits.

@continue
Copy link
Contributor

continue bot commented Dec 11, 2025

All Green - Keep your PRs mergeable

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

@uinstinct uinstinct marked this pull request as ready for review December 12, 2025 04:42
@uinstinct uinstinct requested a review from a team as a code owner December 12, 2025 04:42
@uinstinct uinstinct requested review from Patrick-Erichsen and removed request for a team December 12, 2025 04:42
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 12, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant