bug(tool-call): lsTools should not default to "/", use "." instead #9141
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
dosubot
bot
added
the
size:XS
|
All contributors have signed the CLA ✍️ ✅ |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Author
|
I have read the CLA Document and I hereby sign the CLA |
When a tool call want's to list "." it is very likely refering to the current directory and not the root-directory ("/"). Also if the directory parameter is missing it makes more sense to list the current work dir, not root ("/").
carcinoma
force-pushed
the
bugfix/ls-tool-must-not-default-to-root
branch
from
5ef51e4 to
b496e5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a tool call want's to list "." it is very likely refering to the current directory and not the root-directory ("/"). Also if the directory parameter is missing it makes more sense to list the current work dir, not root ("/").
Summary by cubic
Use "." as the default directory in lsTool so listings target the current working directory instead of "/". Prevents accidental root listings when the dir argument is missing or set to ".".
Written for commit b496e5c. Summary will update automatically on new commits.