Generalize exa_linalg to AbstractVector/AbstractMatrix #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace concrete Vector/Matrix types with AbstractVector/AbstractMatrix
in all function signatures to support views, reshape, and other abstract
array types. This enables operations on SubArray, ReshapedArray, and
transposed arrays without creating copies.
Changes:
- Updated ~40 method signatures from Vector/Matrix to Abstract variants
- Added Union{Adjoint, Transpose} methods to resolve ambiguities
- Documented 56 detected ambiguities (24 theoretical, 32 with specialized
types like Diagonal/SparseVector that don't occur in practice)
- Added comprehensive test suite for AbstractArray compatibility
- Updated dimension mismatch tests to accept DimensionMismatch exception
All 439 tests pass. No breaking changes to existing functionality.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
|
Breakage test results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace concrete Vector/Matrix types with AbstractVector/AbstractMatrix in all function signatures to support views, reshape, and other abstract array types. This enables operations on SubArray, ReshapedArray, and transposed arrays without creating copies.
Changes:
All 439 tests pass. No breaking changes to existing functionality.