Skip to content

Guard against multiple snapshots inserted during PUT for given doc #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickbrowne merged 1 commit into from
Oct 23, 2025
Merged

Guard against multiple snapshots inserted during PUT for given doc #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions src/server/db/pg.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,18 +88,31 @@ module.exports = PgDb = (options) ->
callback? error.message

@create = (docName, docData, callback) ->
sql = """
INSERT INTO #{snapshot_table} ("doc", "v", "snapshot", "meta", "type", "created_at")
VALUES ($1, $2, ($3)::jsonb, $4, $5, now() at time zone 'UTC')
# Temporarily guard against improper constraints allowing
# multiple snapshots to be inserted for a given docName
check_snapshots_sql = """
SELECT count("doc") FROM #{snapshot_table}
WHERE "doc" = $1
"""
values = [docName, docData.v, JSON.stringify(docData.snapshot), docData.meta, docData.type]
client.query sql, values, (error, result) ->
if !error?
callback?()
else if error.toString().match "duplicate key value violates unique constraint"

client.query check_snapshots_sql, [docName], (error, result) ->
if !error? and result.rows.length > 0 and result.rows[0].count > 0
callback? "Document already exists"
else
else if error?
callback? error?.message
else
sql = """
INSERT INTO #{snapshot_table} ("doc", "v", "snapshot", "meta", "type", "created_at")
VALUES ($1, $2, ($3)::jsonb, $4, $5, now() at time zone 'UTC')
"""
values = [docName, docData.v, JSON.stringify(docData.snapshot), docData.meta, docData.type]
client.query sql, values, (error, result) ->
if !error?
callback?()
else if error.toString().match "duplicate key value violates unique constraint"
callback? "Document already exists"
else
callback? error?.message

@delete = (docName, dbMeta, callback) ->
sql = """
Expand Down