Skip to content

Setting in progress text and query caching #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phillipj wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Setting in progress text and query caching #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 22 additions & 7 deletions jquery.jsonSuggest-2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,11 @@
highlightMatches: true,
onSelect: undefined,
width: undefined,
property: 'text'
property: 'text',
searchProgressText: 'Searching...'
},
getJSONTimeout;
getJSONTimeout,
lastQueryText;
settings = $.extend(defaults, settings);

return this.each(function() {
Expand Down Expand Up @@ -107,7 +109,7 @@
*/
function selectResultItem(item) {
obj.val(item[settings.property]);
$(results).html('').hide();
clearAndHideResults();

if (typeof settings.onSelect === 'function') {
settings.onSelect(item);
Expand All @@ -134,12 +136,14 @@
* on in the settings.
*/
function buildResults(resultObjects, filterTxt) {
lastQueryText = filterTxt;

filterTxt = '(' + filterTxt + ')';

var bOddRow = true, i, iFound = 0,
filterPatt = settings.caseSensitive ? new RegExp(filterTxt, 'g') : new RegExp(filterTxt, 'ig');

$(results).html('').hide();
clearAndHideResults();

for (i = 0; i < resultObjects.length; i += 1) {
var item = $('<li />'),
Expand Down Expand Up @@ -194,7 +198,11 @@
* run a match against each item in the possible results and display any
* results on the page allowing selection by the user.
*/
function runSuggest(e) {
function runSuggest(e) {
if (!hasQueryTextChanged(this)) {
return;
}

var search = function(searchData) {
if (this.value.length < settings.minCharacters) {
clearAndHideResults();
Expand Down Expand Up @@ -235,7 +243,7 @@
return false;
}

$(results).html('<li class="ui-menu-item ajaxSearching"><a class="ui-corner-all">Searching...</a></li>').
$(results).html('<li class="ui-menu-item ajaxSearching"><a class="ui-corner-all">'+ settings.searchProgressText +'</a></li>').
show().css('height', 'auto');

getJSONTimeout = window.clearTimeout(getJSONTimeout);
Expand All @@ -257,7 +265,14 @@
*/
function clearAndHideResults() {
$(results).html('').hide();
}
}

/**
* Whether or not the search query has changed since the last results was build
*/
function hasQueryTextChanged(domElement) {
return domElement.value !== lastQueryText;
}

/**
* To call specific actions based on the keys pressed in the input
Expand Down