cmd-build-with-buildah: rework calling versionary

[dustymabe]

• cmd-build-with-buildah: pass --build-args to versionary
• cmd-build-with-buildah: refactor versionary logic
• cmd-build-with-buildah: move version logic into function

[gemini-code-assist]

Code Review

This pull request refactors how the versionary script is called by moving the logic into the build_with_buildah function and passing the --build-args parameter. The changes are well-structured and improve the script's logic. I have one suggestion to further enhance the code by using a bash array to construct arguments, which is a more robust and readable approach.

[gemini-code-assist]

To improve robustness and readability, consider building the arguments for the versionary command in an array. This practice avoids potential word-splitting issues with unquoted variables and makes the argument construction clearer.

        local versionary_args=("--build-args=src/config/${argsfile}")
        if [ -z "${VERSIONARY}" ]; then
            versionary_args+=('--dev')
        fi
        # Call versionary. Let it error out if file does not exist.
        VERSION=$(src/config/versionary "${versionary_args[@]}")

[marmijo]

LGTM