cmd-build-with-buildah: drop reading from manifest #4426
Merged
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request successfully removes manifest file parsing for build configuration, aligning with the goal of moving build arguments out of manifests. However, the new method for extracting the 'stream' variable introduces a potential security vulnerability due to the use of 'eval' and a functional bug in handling cases where the 'STREAM' variable is not defined in the configuration file.
dustymabe
force-pushed
the
dusty-drop-manifest-req
branch
from
cae9015 to
d89c1e5
Compare
Member
Author
|
/retest |
We can pickup the stream from the build-args now so let's do that because we are moving more and more stuff out of the manifests themselves.
dustymabe
force-pushed
the
dusty-drop-manifest-req
branch
from
d89c1e5 to
c8e65cc
Compare
dustymabe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can pickup the stream from the build-args now so let's do that because we are moving more and more stuff out of the manifests themselves.