enabled pedantic clippy lints

Cargo.toml

@@ -15,7 +15,7 @@ gpgme = "0.11"
 chrono = { version = "0.4", default-features = false, features = ["clock"] }
 git2 = "0.20"
 rand = "0.9"
-whoami = "1"
+whoami = "2"
 toml = "0.9"
 reqwest = { version = "0.13", features = ["blocking"] }
 hex = "0.4"
@@ -36,6 +36,9 @@ flate2 = "1"
 tar = "0.4"
 criterion = "0.8"
 
+[lints.clippy]
+pedantic = "warn"
+
 [workspace]
 
 members = [

benches/library_benchmark.rs

@@ -30,12 +30,12 @@ fn cleanup(mut base_path: PathBuf, path_name: &str) -> Result<(), std::io::Error
 fn pop_list(password_dir: PathBuf) -> pass::Result<()> {
     let store = pass::PasswordStore::new(
         "",
-        &Some(password_dir),
-        &None,
-        &None,
-        &None,
-        &CryptoImpl::GpgMe,
-        &None,
+        Some(&password_dir),
+        None,
+        None,
+        None,
+        CryptoImpl::GpgMe,
+        None,
     )?;
     let results = store.all_passwords().unwrap();
 

cursive/Cargo.toml

@@ -17,7 +17,6 @@ ripasso = { path = "../", version = "0.8.0" }
 locale_config = "0.3"
 unic-langid = "0.9"
 gettext = "0.4"
-lazy_static = "1"
 terminal_size = "0.4"
 hex = "0.4"
 zeroize = { version = "1", features = ["zeroize_derive", "alloc"] }
@@ -28,9 +27,12 @@ default-features = false
 features = ["toml"]
 
 [dev-dependencies]
-tempfile = "3.10.1"
+tempfile = "3"
 chrono = { version = "0.4", default-features = false, features = ["clock"] }
 
 [build-dependencies]
 glob = "0.3"
 man = "0.3"
+
+[lints.clippy]
+pedantic = "warn"

cursive/build.rs

@@ -65,15 +65,15 @@ fn generate_man_page_file() {
     dest_path.pop();
     dest_path.pop();
     dest_path.push("man-page");
-    print!("creating directory: {:?} ", &dest_path);
+    print!("creating directory: {} ", dest_path.display());
     let res = std::fs::create_dir(&dest_path);
     if res.is_ok() {
         println!("success");
     } else {
         println!("error: {:?}", res.err().unwrap());
     }
     dest_path.push("cursive");
-    print!("creating directory: {:?} ", &dest_path);
+    print!("creating directory: {} ", dest_path.display());
     let res = std::fs::create_dir(&dest_path);
     if res.is_ok() {
         println!("success");
@@ -94,15 +94,15 @@ fn generate_translation_files() {
     dest_path.pop();
     dest_path.pop();
     dest_path.push("translations");
-    print!("creating directory: {:?} ", &dest_path);
+    print!("creating directory: {} ", dest_path.display());
     let res = std::fs::create_dir(&dest_path);
     if res.is_ok() {
         println!("success");
     } else {
         println!("error: {:?}", res.err().unwrap());
     }
     dest_path.push("cursive");
-    print!("creating directory: {:?} ", &dest_path);
+    print!("creating directory: {} ", dest_path.display());
     let res = std::fs::create_dir(&dest_path);
     if res.is_ok() {
         println!("success");
@@ -128,8 +128,8 @@ fn generate_translation_files() {
         filename.replace_range(3..4, "m");
 
         print!(
-            "generating .mo file for {:?} to {}/{} ",
-            &file,
+            "generating .mo file for {} to {}/{} ",
+            file.display(),
             dest_path.display(),
             &filename
         );

cursive/src/helpers.rs

@@ -14,21 +14,19 @@
     along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
 
-use std::sync::{Arc, Mutex};
+use std::sync::{Arc, LazyLock, Mutex};
 
 use arboard::Clipboard;
 use cursive::{
     Cursive,
     event::Key,
     views::{Checkbox, Dialog, EditView, OnEventView, RadioButton, TextView},
 };
-use lazy_static::lazy_static;
 use pass::Result;
 use ripasso::{crypto::CryptoImpl, pass, pass::Recipient};
 
-lazy_static! {
-    static ref CLIPBOARD: Arc<Mutex<Clipboard>> = Arc::new(Mutex::new(Clipboard::new().unwrap()));
-}
+static CLIPBOARD: LazyLock<Arc<Mutex<Clipboard>>> =
+    LazyLock::new(|| Arc::new(Mutex::new(Clipboard::new().unwrap())));
 
 /// Displays an error in a cursive dialog
 pub fn errorbox(ui: &mut Cursive, err: &pass::Error) {
@@ -52,7 +50,7 @@ pub fn errorbox(ui: &mut Cursive, err: &pass::Error) {
 }
 
 /// Copies content to the clipboard.
-pub fn set_clipboard(content: &String) -> Result<()> {
+pub fn set_clipboard(content: &str) -> Result<()> {
     Ok(CLIPBOARD.lock().unwrap().set_text(content)?)
 }