Skip to content

Conversation

@corwinm
Copy link
Owner

@corwinm corwinm commented Oct 12, 2025

feat: Add config to disable '_' keybind

πŸ“ Description

This PR adds a config option to disable the '_' keybind

πŸ”§ Type of Change

  • πŸ› Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • ♻️ Code refactoring (no functional changes)
  • ⚑ Performance improvement
  • πŸ§ͺ Tests (adding missing tests or correcting existing tests)
  • 🎨 Style changes (formatting, missing semi-colons, etc)
  • πŸ”§ Chore (maintenance tasks, dependency updates)
  • 🌟 Other (please describe):

πŸ”— Related Issues

Resolves #49

Testing

  • I have tested this change locally
  • I have added/updated unit tests
  • All existing tests pass

Screenshots (if applicable)

Checklist

  • My code follows the project's coding standards
  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

Additional Notes

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a configuration option to disable the '_' (underscore) keybind that opens the current working directory, allowing users to use the default Vim motion behavior instead.

  • Added disableUnderscoreOpenCwd configuration setting with appropriate description
  • Implemented conditional keymap registration based on the new setting
  • Updated VSCode keybinding conditions to respect the configuration

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/vim/oil.code.lua Added conditional registration of the '_' keybind based on configuration setting
src/utils/settings.ts Added getter function for the new configuration option
package.json Added configuration schema and updated keybinding condition

@corwinm corwinm merged commit 178d2ab into main Oct 16, 2025
4 checks passed
@corwinm corwinm deleted the feat/disable-under-keybind branch October 16, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Change default vim shortcut for command oil-code.openCwd to something else

2 participants