[4.0.3 backport] CBG-5146: Support replacement revs for non-filtered replications #8045
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports a fix for CBG-5146 to support replacement revs for non-filtered replications. The issue was that replacement revisions were incorrectly being blocked when no channel filter was specified, even though the client opted in to receiving them.
Changes:
- Fixed the channel filter check to allow replacement revs when no filter is specified (nil channels)
- Added test coverage for the non-filtered replication scenario
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| db/blip_sync_context.go | Added nil check for collectionCtx.channels to support replacement revs in non-filtered replications |
| rest/blip_api_crud_test.go | Added test case for replacement revs with no channel filter and parameterized replication channels in test table |
gregns1
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean cherry-pick of #8043 for 4.0.3
Integration Tests