Update to use micromatch #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replaces minimatch with micromatch - adds a new test
|
Great work. Would love to see this merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to use micromatch instead of minimatch.
This change addresses the performance and safety issues that have been found in minimatch. For more general information on why to use micromatch, this section goes over the features. Also, the braces readme has more information about why it's safer.
Additional information
Using micromatch resolves #25, since micromatch has more complete extglob support. A test has been added for this use case.
You can also close #10, since
{ignore: ['**/node_modules/**']}will achieve the desired result.