[lex.charset] Move reference to glyphs to appropriate place #8418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlisdairM
force-pushed
the
move_glyph_documentation
branch
from
0df6fc5 to
cbdbe3d
Compare
jensmaurer
requested changes
Dec 6, 2025
jensmaurer
added
the
changes requested
AlisdairM
force-pushed
the
move_glyph_documentation
branch
from
cbdbe3d to
036f558
Compare
jensmaurer
approved these changes
Dec 6, 2025
jensmaurer
added
after-motions
tkoeppe
added
the
needs rebase
Contributor
|
@AlisdairM: Please rebase. |
The statement that glyphs are used to identify members of the basic character set does not belong separating two sentences introducing and then defining preprocessing tokens. Also, we do not *exlusively* use glyphs for this purpose but also directly call out Unicode code points too, so tone down the phrasing to glyphs are *often* used to ...
AlisdairM
force-pushed
the
move_glyph_documentation
branch
from
036f558 to
b88985d
Compare
Contributor
Author
|
This has been rebased, and should be ready to merge. |
jensmaurer
removed
the
needs rebase
Member
|
@tkoeppe , this is ready now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The statement that glyphs are used to identify members of the basic character set does not belong separating two sentences introducing and then defining preprocessing tokens.
Also, we do not exlusively use glyphs for this purpose but also directly call out Unicode code points too, so tone down the phrasing to glyphs are often used to ...