Skip to content

Conversation

@alandefreitas
Copy link
Collaborator

@alandefreitas alandefreitas commented Dec 6, 2025

Fixes #881, moves us closer on #1113.

  • Swapped Duktape for JerryScript across CMake, CI, presets, bootstrap recipe, and the install
    docs; added a small port layer so it all hooks up cleanly.
  • Tightened the JS helper runtime: shared context lifetime, safer value accessors, clearer errors,
    and helper registration that keeps options/hash intact for block helpers; added unit tests to cover
    the new paths.
  • Added an addons-supplemental config option so you can layer extra addons/overrides; documented it and
    dropped in golden fixtures for the JS helpers. Also cleaned up the TestRunner include path.

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

🚧 Danger.js checks for MrDocs are experimental; expect some rough edges while we tune the rules.

⚠️ Warnings

Warning

Commit e40913d (feat: javascript helpers extension) changes 4776 source lines. Consider splitting it into smaller, reviewable chunks.

✨ Highlights

  • 🧪 Existing golden tests changed (behavior likely shifted)

🧾 Changes by Scope

Scope Lines Δ Lines + Lines - Files Δ Files + Files ~ Files ↔ Files -
Source 4776 2643 2133 -3 1 7 - 11
Tests 1338 1092 246 2 - 2 - -
Golden Tests 324 324 - 50 31 - 19 -
CI / Roadmap 321 244 77 9 1 8 - -
Third-party 312 172 140 - 3 - - 3
Docs 112 34 78 3 - 3 - -
Build / Toolchain 34 20 14 3 - 3 - -
Other 25 3 22 - - 1 - 1
Total 7242 4532 2710 64 36 24 19 15

Legend: Files + (added), Files ~ (modified), Files ↔ (renamed), Files - (removed)

🔝 Top Files

  • src/lib/Support/JavaScript.cpp (Source): 3479 lines Δ (+1884 / -1595)
  • src/test/Support/JavaScript.cpp (Tests): 1335 lines Δ (+1091 / -244)
  • include/mrdocs/Support/JavaScript.hpp (Source): 428 lines Δ (+206 / -222)

Generated by 🚫 dangerJS against e40913d

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 6, 2025

An automated preview of the documentation is available at https://1126.mrdocs.prtest2.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2025-12-17 07:57:28 UTC

@alandefreitas alandefreitas force-pushed the develop branch 3 times, most recently from f689c23 to e9faceb Compare December 7, 2025 03:31
@alandefreitas alandefreitas force-pushed the develop branch 6 times, most recently from f043207 to db51f18 Compare December 9, 2025 06:12
@alandefreitas alandefreitas force-pushed the develop branch 12 times, most recently from 96578fe to bc3cd80 Compare December 16, 2025 03:54
@alandefreitas alandefreitas force-pushed the develop branch 11 times, most recently from 2293cbb to 88250ba Compare December 17, 2025 03:20
@alandefreitas alandefreitas force-pushed the develop branch 3 times, most recently from ca3a5da to 923a646 Compare December 17, 2025 06:29
@alandefreitas alandefreitas merged commit 0f3ecb4 into cppalliance:develop Dec 17, 2025
18 checks passed
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (c3dbded) to head (e40913d).
⚠️ Report is 9 commits behind head on develop.

Additional details and impacted files
@@       Coverage Diff       @@
##   develop   #1126   +/-   ##
===============================
===============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alandefreitas alandefreitas mentioned this pull request Dec 17, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explore Javascript Engines

2 participants