Skip to content

Fix webhook mock expectations for retry in tests #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tomach merged 1 commit into from
Jan 21, 2026
Merged

Fix webhook mock expectations for retry in tests #803

tomach merged 1 commit into from
Jan 21, 2026

Conversation

@tomach
Copy link
Contributor

@tomach tomach commented Jan 20, 2026 •
edited
Loading

Summary of changes

Fix webhook notification mocks after function signature change

Checklist

  • Link to issue this PR refers to: https://github.com/crate/cloud/issues/2818
  • Relevant changes are reflected in CHANGES.rst
  • Added or changed code is covered by tests
  • Documentation has been updated if necessary
  • Changed code does not contain any breaking changes (or this is a major version change)

@tomach tomach marked this pull request as ready for review January 20, 2026 14:49
plaharanne
plaharanne approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@plaharanne plaharanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomach tomach force-pushed the ta/fix-webhook-tests branch from 3d64b06 to 370808d Compare January 21, 2026 09:07
@tomach tomach merged commit 8674184 into master Jan 21, 2026
15 checks passed
@tomach tomach deleted the ta/fix-webhook-tests branch January 21, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plaharanne plaharanne plaharanne approved these changes

@juanpardo juanpardo Awaiting requested review from juanpardo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomach @plaharanne