Skip to content

Conversation

@coolgw
Copy link
Contributor

@coolgw coolgw commented Feb 11, 2020

After check this file, i find some garbage code, so i remove this part from the code.

@wjn740
Copy link
Contributor

wjn740 commented Feb 11, 2020

@aleksei-burlakov

@coolgw coolgw force-pushed the master branch 3 times, most recently from 877cb03 to 0722b03 Compare February 12, 2020 01:16
@wjn740
Copy link
Contributor

wjn740 commented Feb 12, 2020

I run this patch in my environment. It's worked. so I think it is safe to merge.

@wjn740
Copy link
Contributor

wjn740 commented Feb 12, 2020

But it caused can't output e820 memory map on desktop. I don't know if it is root cause. I'm researching.

@wjn740
Copy link
Contributor

wjn740 commented Feb 12, 2020

jnwang@linux-g6xe: pts/5: 13 files 276Kb  ((8a6b11f...)|BISECTING)-> git bisect good
877cb03293a3df17884c874fdb183d1e88796dd4 is the first bad commit
commit 877cb03293a3df17884c874fdb183d1e88796dd4
Author: coolgw <wegao@suse.com>
Date:   Tue Feb 11 19:44:55 2020 +0800

    optimise bootsector code

 bsp/x86/bootsector.s    | 37 ++++++++-----------------------------
 bsp/x86/lowlevel_init.s |  4 ++--
 buildrules/linker.rules |  3 +++
 3 files changed, 13 insertions(+), 31 deletions(-)

@wjn740
Copy link
Contributor

wjn740 commented Feb 12, 2020

@coolgw unfortunately, it's a bad patch, it caused the e820 memory detector failure. Please take a look.

@coolgw
Copy link
Contributor Author

coolgw commented Feb 12, 2020

@coolgw unfortunately, it's a bad patch, it caused the e820 memory detector failure. Please take a look.

fixed it now, you can try again.

@wjn740
Copy link
Contributor

wjn740 commented Feb 16, 2020

you need to review resolve conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants