Adds support to the VT service for uploading unknown samples #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds support to upload samples not previously seen by VT.
- This is controlled by a configuration and runtime option.
- To minimize request to VT, the service will wait a default amount of time before attempt to retrieve the results. This was done as VT changes and throttles based on number of queries.
- This update now leverages python requests verses urllib2.
We tested this with samples through CRITs triage and runtime functions.
P.S. This was mostly modified by a student of mine and not me. He does not wish to put him name out there which is why I am uploading it. Also, I apologize that auto merging is not working...I have no idea why.