Skip to content

refactor(client): split USK fetcher attempts #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
leumor wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

refactor(client): split USK fetcher attempts #896

leumor wants to merge 8 commits into from

Conversation

@leumor
Copy link
Collaborator

@leumor leumor commented Jan 18, 2026

Summary

  • split USK fetcher attempt lifecycle into dedicated attempt/context/manager helpers
  • add completion handler/coordinator for retained data and callback delivery
  • simplify USKFetcher scheduling, cancellation, and polling flow around new helpers

Testing

  • not run

leumor added 8 commits January 17, 2026 20:55
@leumor
refactor(client): split USK attempt handling
d8a1030 
Move attempt state/scheduling into USKAttempt and USKAttemptManager to reduce USKFetcher dependencies.
Increase BootstrapSeedTestTest subprocess timeout to reduce flakiness.
@leumor
refactor(client): modularize USK fetcher flow
812199c 
Extract attempt, scheduling, polling, and completion helpers to clarify USK fetcher coordination.
@leumor
docs(client): expand USK fetcher docs
95222c9 
Clarify USKFetcher lifecycle, scheduling, and callbacks; avoid exposing Buckets when checking retained data.
@leumor
docs(client): expand USK async docs
c3828bc
@leumor
fix(client): harden USK async fixes
b58e955
@leumor
test(client): tighten USK attempt test expectations
d68edc7 
Align assertions with intent and simplify test helpers to make priority behavior checks clearer and less error-prone during future refactors.
@leumor
test(client): cover USKAttemptManager
4ba553d 
Add deterministic unit tests for attempt staging, cancellation, and scheduling flows.
@leumor
test(client): cover USKCompletionCoordinator
1183303
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 19, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
39.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leumor