Skip to content

feat: update system-time rule to not trigger on time.Now().Round(0).UTC() #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julienrbrt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: update system-time rule to not trigger on time.Now().Round(0).UTC() #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/system-time.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ predicate isIrrelevantPackage(string packageName) {
from CallExpr call
where
call.getTarget().getQualifiedName() = "time.Now" and
not call.getParent().(CallExpr).getTarget().getQualifiedName() = "Round" and
not call.getParent*().(CallExpr).getTarget().getQualifiedName() = "UTC" and
// string formatting is usually a false positive (used in logging etc.),
// so it's usually ok to ignore.
// but there could be false negatives (if the string formatting output is written to a consensus state)
Expand Down Expand Up @@ -46,4 +48,5 @@ where
|
c.getAComment().getText().matches("%SAFE:%")
)
select call, "Calling the system time may be a possible source of non-determinism"
select call,
"Calling the system time may be a possible source of non-determinism. Use time.Now().Round(0).UTC() instead."