Skip to content

Conversation

@mindmonk
Copy link
Contributor

This PR addresses the issue described in #283 by adjusting the visibility logic of the vault action buttons.

The change removes the isAdmin check from the v-if condition controlling the Archive Vault / Reactivate Vault buttons. As a result, these actions are no longer shown to admin users who do not have ownership permissions for the vault.

This is a small UI-only change that:

  • Prevents admins without ownership rights from seeing actions they are not allowed to perform
  • Avoids failed archive/reactivate attempts that currently result in a 403 Forbidden response from the backend

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 17, 2025

Walkthrough

The pull request modifies frontend/src/components/VaultDetails.vue to restrict vault management actions (archiveVault, reactivateVault, and related buttons) to the OWNER role only, removing conditional branches that previously allowed admin users. The internal isAdmin state and its initialization were removed. No other data-fetching or error-handling behavior was changed. CHANGELOG.md was updated with a Fixed entry describing the change.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • SailReal
  • overheadhunter
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: hiding Archive/Reactivate Vault actions for admins without ownership rights, which aligns with the changeset.
Description check ✅ Passed The description is directly related to the changeset, explaining the visibility logic changes and their purpose, with appropriate level of detail.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 43a17a6 and 91f0dba.

📒 Files selected for processing (1)
  • CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Run Tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@overheadhunter overheadhunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention this in CHANGELOG.md

@overheadhunter overheadhunter added this to the 1.5.0 milestone Jan 9, 2026
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @CHANGELOG.md:
- Line 154: The changelog entry "Hide Archive/Reactivate Vault actions for
admins without ownership rights (#379)" is incorrectly placed under the
[1.4.0-rc2] section; remove that line from the [1.4.0-rc2] section and add the
exact same line under the [Unreleased] section inside the "### Fixed" subsection
so the entry appears in Unreleased until the next release.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d5ebf6e and ab9c2b7.

📒 Files selected for processing (1)
  • CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Run Tests

@mindmonk mindmonk merged commit f94a7bf into develop Jan 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants