-
-
Notifications
You must be signed in to change notification settings - Fork 16
Feature: Hide Archive/Reactivate Vault actions for admins without ownership rights #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Hide Archive/Reactivate Vault actions for admins without ownership rights #379
Conversation
WalkthroughThe pull request modifies frontend/src/components/VaultDetails.vue to restrict vault management actions (archiveVault, reactivateVault, and related buttons) to the OWNER role only, removing conditional branches that previously allowed admin users. The internal Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
overheadhunter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mention this in CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @CHANGELOG.md:
- Line 154: The changelog entry "Hide Archive/Reactivate Vault actions for
admins without ownership rights (#379)" is incorrectly placed under the
[1.4.0-rc2] section; remove that line from the [1.4.0-rc2] section and add the
exact same line under the [Unreleased] section inside the "### Fixed" subsection
so the entry appears in Unreleased until the next release.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Run Tests
This PR addresses the issue described in #283 by adjusting the visibility logic of the vault action buttons.
The change removes the isAdmin check from the v-if condition controlling the Archive Vault / Reactivate Vault buttons. As a result, these actions are no longer shown to admin users who do not have ownership permissions for the vault.
This is a small UI-only change that: