Skip to content

Conversation

@peinjoh
Copy link
Contributor

@peinjoh peinjoh commented Jan 5, 2026

resolves #114

@peinjoh peinjoh requested a review from a team as a code owner January 5, 2026 10:05

/// Returns the textual description of the product
fn get_name(&self) -> &String;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an error on my part, I needed the name of the branch, not of the product. This is not used by the test, I'm still leaving it in, though.

@peinjoh
Copy link
Contributor Author

peinjoh commented Jan 5, 2026

@tschmidtb51 One remark on this: Test case 6-1-31-12 contains a branch with name after-eight, but is a valid case. This was also highlighted by @oxisto here: oasis-tcs/csaf#825

This was remediated in version 2.1 of the standard, which introduces the need for tokenization before checking for the "forbidden" words (i.e. before, after, ...) based on the suggestion in the issue above.

Still, this test case being valid contradicts the standard, as after-eight contains after. I implemented the test by using the tokenization for both 2.0 and 2.1 documents, is this the intended / correct implementation specifically for CSAF 2.0 documents?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement 6.1.31 Version Range in Product Version

2 participants