Warlockxins task 2 #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warlockxins
commented
Oct 28, 2025
src/main/java/lv/ctco/springboottemplate/config/ResponseFormatConverter.java
Outdated
Show resolved
Hide resolved
warlockxins
commented
Oct 28, 2025
src/main/java/lv/ctco/springboottemplate/features/statistics/StatisticsService.java
Show resolved
Hide resolved
Test Results18 tests 18 ✅ 1s ⏱️ Results for commit 9e57c09. ♻️ This comment has been updated with latest results. |
BagumEpmak
reviewed
Nov 3, 2025
src/main/java/lv/ctco/springboottemplate/features/statistics/StatisticsController.java
Outdated
Show resolved
Hide resolved
BagumEpmak
reviewed
Nov 3, 2025
src/main/java/lv/ctco/springboottemplate/features/statistics/StatisticsController.java
Outdated
Show resolved
Hide resolved
BagumEpmak
reviewed
Nov 3, 2025
src/main/java/lv/ctco/springboottemplate/features/statistics/StatisticsController.java
Outdated
Show resolved
Hide resolved
BagumEpmak
reviewed
Nov 23, 2025
|
|
||
| if (from != null && to != null) { | ||
| criteria = Criteria.where("createdAt").gte(from).lte(to); | ||
| criteria.lte(to); |
BagumEpmak
reviewed
Nov 23, 2025
src/main/java/lv/ctco/springboottemplate/features/statistics/TodoStatsRepository.java
Show resolved
Hide resolved
BagumEpmak
reviewed
Nov 23, 2025
| this.mongoTemplate = mongoTemplate; | ||
| } | ||
|
|
||
| Aggregation getSummaryStatsAggregation(ResponseFormat format, Instant from, Instant to) { |
Collaborator
There was a problem hiding this comment.
IMO it should be a private method
BagumEpmak
reviewed
Nov 23, 2025
| } else if (to != null) { | ||
| criteria = Criteria.where("createdAt").lte(to); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Looks like lines 23-32 should be:
Criteria criteria = new Criteria();
if (from != null) {
criteria.gte(from);
}
if (to != null) {
criteria.lte(to);
}
BagumEpmak
reviewed
Nov 23, 2025
| Criteria criteria = new Criteria(); | ||
|
|
||
| if (from != null && to != null) { | ||
| criteria = Criteria.where("createdAt").gte(from).lte(to); |
Collaborator
There was a problem hiding this comment.
It's better to have string constans or enums for field names
BagumEpmak
reviewed
Nov 23, 2025
| return Aggregation.newAggregation(matchStage, countsFacet, project); | ||
| } | ||
|
|
||
| Long extractLong(Document doc, String key) { |
BagumEpmak
reviewed
Nov 23, 2025
| Map<String, Long> userStats = | ||
| userStatsList.stream() | ||
| .collect( | ||
| java.util.stream.Collectors.toMap( |
Collaborator
There was a problem hiding this comment.
why do you need package name (java.util.stream) as a prefix?
BagumEpmak
reviewed
Nov 23, 2025
| userStatsList.stream() | ||
| .collect( | ||
| java.util.stream.Collectors.toMap( | ||
| d -> d.getString("_id"), d -> ((Number) d.get("count")).longValue())); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was fun, and was able to experiment with more global config with spring.