Kirill topchy ctco task/2 #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rillTopchyCtco-task/1
…rillTopchyCtco-task/1
…rillTopchyCtco-task/1
KirillTopchyCtco
requested review from
IgorGursky,
Melancholic,
algorithm108,
trioletas and
vchekushin-ctco
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 7e1f418. ♻️ This comment has been updated with latest results. |
| public static Map<String, Integer> extractUserStats(Document root) { | ||
| if (root == null) return Map.of(); | ||
| List<Document> userStatsDocs = getArray(root, "userStats"); | ||
| Map<String, Integer> map = new LinkedHashMap<>(); |
Collaborator
There was a problem hiding this comment.
It is better to create map using stream on userStatsDocs
| @ApiResponse(responseCode = "500", description = "Internal server error", content = @Content(schema = @Schema(implementation = StatisticsErrorResponse.class))) | ||
| } | ||
| ) | ||
| public ResponseEntity<?> getStatistics(StatisticsRequest request) { |
Collaborator
There was a problem hiding this comment.
Why "?"? Is response class unknown?
|
|
||
| import java.util.List; | ||
|
|
||
| @RestControllerAdvice(assignableTypes = StatisticsController.class) |
Collaborator
There was a problem hiding this comment.
Why not global exception handler but only for statistic controller? I see that you have specific return type for this, but it is better to come up with universal error class structure, which will be used by all controllers
| public class StatisticsQueryBuilder { | ||
| public StatisticsQuery build(StatisticsRequest request) { | ||
| List<String> errors = new ArrayList<>(); | ||
| LocalDate from = parseDate("from", request.from(), errors); |
Collaborator
There was a problem hiding this comment.
As an option you might use validation framework and that use @Valid in controller
vchekushin-ctco
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As i do not have access to Docker, I have changed tests to work with local mongo db instance on port 27017