Skip to content

WIP: Migrate to SDK 2 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aschereT wants to merge 33 commits into
base: master
Choose a base branch
from
Open

WIP: Migrate to SDK 2 #10

aschereT wants to merge 33 commits into from

Conversation

@aschereT
Copy link

@aschereT aschereT commented Jan 9, 2020

This is a PR to migrate this op to SDK 2, following the official migration guide.

Vincent Tan added 20 commits January 7, 2020 14:29
Update packages
5e1480b 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Update @cto.ai/sdk version to ^2. Sort imports, and replace console.l…
f2e4f55 
…og with ux.print.

Builds will be broken while undergoing conversion.

Signed-off-by: Vincent Tan <vincent@cto.ai>
Await ux.print. Fix tests.
214d109 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Temporarily fix prints that are now async, inside non-async functions
771d05d 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Removed inquirer. Use sdk for types
856c36f 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Removed empty input validation, as SDK does that. Further remove inqu…
f84eed0 
…irer references.

Signed-off-by: Vincent Tan <vincent@cto.ai>
Reimplement validated prompts. Use Question typing alias
bbe6748 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Further progress in migrating to SDK 2
411be5f 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Rename validatedPrompts file to promptUtils
6bcbb16 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Fleshed out keyValPrompt
7157d88 
Signed-off-by: Vincent Tan <vincent@cto.ai>
keyValPrompt now supports multiple Question types
8ba3363 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Migrations to SDK 2 for a few more commands
316a51c
Migrate pulls:list and repo:clone to SDK 2
bc755fa
Migrated all commands to SDK 2
13e2d73
Optional chaining is not supported yet by the node version in base image
a7026f4
Fix building
2930212 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Update dependencies, remove dead dependencies, add package-lock.json …
90285ee 
…during build
Use ux.print to print to stdout
d4d2b4a 
Signed-off-by: Vincent Tan <vincent@cto.ai>
await spinners
29ec2de
Remove unused autocomplete stuff
a46d7c6 
Signed-off-by: Vincent Tan <vincent@cto.ai>
@aschereT aschereT added the enhancement New feature or request label Jan 9, 2020
@aschereT aschereT self-assigned this Jan 9, 2020
ruxandrafed
ruxandrafed suggested changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@ruxandrafed ruxandrafed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this migration! Please cleanup any commented lines and ensure all TODOS are handled without any regression from the previous version. Function documentation should be consistent as far as formatting is concerned, and no need to explain in detail every step of every function. Leverage TypeScript to ensure the right types are passed into functions, and maybe refactor some of the variable names to improve legibility where possible..

Also, very important: whenever things were removed to ensure compatibility with SDK 2, can we please ensure there are no regressions as far as the user interactions are concerned? Thank you!

Vincent Tan added 5 commits January 16, 2020 16:27
Remove commented out code
72afd34 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Cleaned up commented out code
66f6b1d 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Bump version to v1.1.0
592f93b 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Validate message for issue:save
b1007c1 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Fixed missing NOT
ae8fc09 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Vincent Tan added 7 commits January 16, 2020 16:39
Renamed symbol nameList -> choicesArr
85adcd6 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Cleaned up promptUtils
251af04 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Add typing to keyValPrompt and update packages
5a2a104 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Remove TODO
e342ddf 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Revert debugging-only function from ux.print back to console.log
71251fc 
Signed-off-by: Vincent Tan <vincent@cto.ai>
validatedPrompt error message is now optional
4550c84 
Signed-off-by: Vincent Tan <vincent@cto.ai>
Improve comments for promptUtils functions
5f75372 
Signed-off-by: Vincent Tan <vincent@cto.ai>
@aschereT aschereT requested a review from ruxandrafed January 21, 2020 00:39
@aschereT aschereT changed the title Migrate to SDK 2 WIP: Migrate to SDK 2 Jan 22, 2020
@aschereT
Copy link
Author

aschereT commented Jan 22, 2020

Just realized this op utilises sdk.config, which breaks a lot of functionality when moving to SDK2.

Fix typo breaking keyValPrompt
528d03a 
Signed-off-by: Vincent Tan <vincent@cto.ai>
@aschereT
Copy link
Author

aschereT commented Jan 23, 2020

Just realized this op utilises sdk.config, which breaks a lot of functionality when moving to SDK2.

I was wrong. This was not the breaking error, it was a typo in keyValPrompt. My bad.

CalHoll
CalHoll approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@CalHoll CalHoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Sorry for the wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruxandrafed ruxandrafed Awaiting requested review from ruxandrafed

1 more reviewer

@CalHoll CalHoll CalHoll approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aschereT aschereT

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aschereT @ruxandrafed @CalHoll