Skip to content

Conversation

@Oliver-ctrlo
Copy link
Contributor

  • Cleaned / modified original tests to use commands for consistency.
  • Commented out some of the failing tests/issues to stop cypress erroring on know issues.
  • Added cypress axe for WCAG accessibility testing within test 15
  • Removed the duplicate test 8 file called data-table as these tests are located elsewhere.
  • Added new test sets for the following areas: table permissions, table actions, curvals, Views, data tables, WCAG and adding/editing a record.

Oliver-ctrlo and others added 3 commits October 14, 2025 11:12
});

context("Basic Add/Delete tests", () => {
// Skipped test: known issue where error not appearing for invalid shorname.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spelling mistake in comment: "shorname".


//commented out the following because they require records in the table to appear
//cy.contains("a", "Download records").should("be.visible");
//cy.contains("a", "Field Data Purge").should("be.visible");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these commented out lines above needed if not used?

`/bulk/clone/`,
`/bulk/update/`,
`/import/`,
// `/view/0`,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this commented code needed?
If there is an issue, maybe it could be stated why for clarity.

//No way to check upload progress so wait 5s
cy.wait(5000);

// Check upload finished without errs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spelling error: "errs".

permissionObject[permissionName] = true;
});
cy.setTablePermissionsByShortName(table_shortname, permissionObject);
// cy.addUserToDefaultGroup('test@example.com');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this commented code needed?

expect(firstFive).to.deep.equal(sortedDesc);
});
cy.get('span.dt-column-title[role="button"]').contains('Number Field').click();
//cy.contains('span.dt-column-title[role="button"]', 'Number Field').click();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this code have errors?

import { ICurvalLayoutBuilder } from "../../support/builders/layout/interfaces";
import { goodPassword, goodUser } from "../../support/constants";

describe("Ceate/edit curvals", () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spelling error.

});

// Update all Date Fields
const dateStr = '2222-01-30';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential indenting mistake?

//cy.get("button.btn-xs[data-delete='rule']")
//.eq(1)
//.click();
//Someone owes me a drink!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the commented code have errors?
And is the last comment needed?

bulkImportRecords(csvFilePath?: string): Chainable;
logout(): Chainable;
deleteCurrentView(): Chainable;
deleteAllViewsForTable(tableName: string): Chainable;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way this could potentially be better formatted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants