-
Notifications
You must be signed in to change notification settings - Fork 3
Remove deprecated PropertyUtil.writeProperty method #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated PropertyUtil.writeProperty method #125
Conversation
- Removed deprecated writeProperty() method from PropertyUtil - Updated all test usages to use setProperty() instead - Cleaned up unused imports and formatting from pre-commit 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Summary of ChangesHello @cuioss, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving code hygiene by removing a long-deprecated method that violated the Command-Query Separation principle. It ensures that all internal usages are updated to the correct alternative and includes minor cleanup of unused imports and formatting, contributing to a cleaner and more maintainable codebase. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This is a great pull request that cleanly removes the deprecated PropertyUtil.writeProperty method. The updates to the test suite are correct and ensure that the functionality remains covered after refactoring. The accompanying cleanups of an unused import and code formatting contribute to better code hygiene. The changes are straightforward, well-executed, and improve the overall quality of the codebase. I have no further suggestions, great work!
|



Summary
PropertyUtil.writeProperty()method (marked for removal since 2.4.1)setProperty()insteadChanges
writeProperty()methodsetProperty()instead ofwriteProperty()Test plan
Related
Closes #123
🤖 Generated with Claude Code