Skip to content

Conversation

@cuioss
Copy link
Owner

@cuioss cuioss commented Oct 6, 2025

Summary

  • Removed deprecated PropertyUtil.writeProperty() method (marked for removal since 2.4.1)
  • Updated all test usages to use setProperty() instead
  • Cleaned up unused imports and formatting

Changes

  • PropertyUtil.java: Removed deprecated writeProperty() method
  • PropertyUtilTest.java: Updated all 7 test methods to use setProperty() instead of writeProperty()
  • LogLevel.java: Removed unused import (from pre-commit cleanup)
  • LogRecordModel.java: Minor formatting fix (from pre-commit cleanup)

Test plan

  • All 794 tests pass
  • Clean build and install successful
  • Javadoc generation successful with no warnings
  • Pre-commit checks passed

Related

Closes #123

🤖 Generated with Claude Code

- Removed deprecated writeProperty() method from PropertyUtil
- Updated all test usages to use setProperty() instead
- Cleaned up unused imports and formatting from pre-commit

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@cuioss cuioss linked an issue Oct 6, 2025 that may be closed by this pull request
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @cuioss, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving code hygiene by removing a long-deprecated method that violated the Command-Query Separation principle. It ensures that all internal usages are updated to the correct alternative and includes minor cleanup of unused imports and formatting, contributing to a cleaner and more maintainable codebase.

Highlights

  • Deprecated Method Removal: The PropertyUtil.writeProperty() method, which was marked for removal since version 2.4.1, has been completely removed from PropertyUtil.java.
  • Test Updates: All existing test usages of the removed writeProperty() method in PropertyUtilTest.java have been updated to use the recommended setProperty() method instead.
  • Code Cleanup: Unused imports have been removed from LogLevel.java and a minor formatting fix was applied to LogRecordModel.java as part of pre-commit cleanup.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is a great pull request that cleanly removes the deprecated PropertyUtil.writeProperty method. The updates to the test suite are correct and ensure that the functionality remains covered after refactoring. The accompanying cleanups of an unused import and code formatting contribute to better code hygiene. The changes are straightforward, well-executed, and improve the overall quality of the codebase. I have no further suggestions, great work!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2025

@cuioss cuioss merged commit a4bce48 into main Oct 6, 2025
11 checks passed
@cuioss cuioss deleted the feature/123-remove-deprecated-decuiosstoolspropertypropertyutilwriteproperty branch October 6, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated de.cuioss.tools.property.PropertyUtil#writeProperty

2 participants