add case insensitive searching for zone names #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Domain names are case insensitive. Searches for a mixed case zone and a lowercase zone with the same symbols (letters) should return the same zone object. This point will be particularly evident when searching for IPv6 arpa domains (zones) created before commit 9f65014 when the default for NetAddr::IP would create v6 addresses in upper case - thus an uppercase ip6.arpa zone. Post commit 9f65014 lowercase zones would be searched for - thus a search miss would occur. Additionally this commit adds tests for case insensitive zone searches, as well as alias searches. Lastly, whitespace was modified for the Zone::search subroutine to elimitate trailing spaces and translate tabs to 4 spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Domain names are case insensitive. Searches for a mixed case zone and a
lowercase zone with the same symbols (letters) should return the same
zone object.
This point will be particularly evident when searching for IPv6 arpa
domains (zones) created before commit 9f65014 when the default for
NetAddr::IP would create v6 addresses in upper case - thus an uppercase
ip6.arpa zone. Post commit 9f65014 lowercase zones would be
searched for - thus a search miss would occur.
Additionally this commit adds tests for case insensitive zone searches,
as well as alias searches.
Lastly, whitespace was modified for the Zone::search subroutine to
elimitate trailing spaces and translate tabs to 4 spaces.