Skip to content

fix: open links with target=_blank in CustomTabs, same behavior as chrome PWAs #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chaserhkj wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: open links with target=_blank in CustomTabs, same behavior as chrome PWAs #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ dependencies {
implementation 'pub.devrel:easypermissions:3.0.0'
implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlinVersion"
implementation "androidx.biometric:biometric:1.1.0"
implementation "androidx.browser:browser:1.4.0"

kapt "com.android.databinding:compiler:3.1.4"

Expand Down
23 changes: 23 additions & 0 deletions app/src/main/java/com/cylonid/nativealpha/WebViewActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
import androidx.annotation.Nullable;
import androidx.appcompat.app.AlertDialog;
import androidx.appcompat.app.AppCompatActivity;
import androidx.browser.customtabs.CustomTabsIntent;
import androidx.core.app.ActivityCompat;
import androidx.core.app.ShareCompat;
import androidx.core.content.ContextCompat;
Expand Down Expand Up @@ -186,6 +187,7 @@ private void setupWebView() {
wv.getSettings().setDomStorageEnabled(true);
wv.getSettings().setAllowFileAccess(true);
wv.getSettings().setBlockNetworkLoads(false);
wv.getSettings().setSupportMultipleWindows(true);
// wv.getSettings().setMixedContentMode(WebSettings.MIXED_CONTENT_COMPATIBILITY_MODE);
this.setDarkModeIfNeeded();

Expand Down Expand Up @@ -724,6 +726,27 @@ public void onShowCustomView(View pView, WebChromeClient.CustomViewCallback pVie
hideSystemBars();
}

@Override
public boolean onCreateWindow(WebView view, boolean isDialog,
boolean isUserGesture, android.os.Message resultMsg) {

WebView newWebView = new WebView(WebViewActivity.this);
view.addView(newWebView);
WebView.WebViewTransport transport = (WebView.WebViewTransport) resultMsg.obj;
transport.setWebView(newWebView);
resultMsg.sendToTarget();

newWebView.setWebViewClient(new WebViewClient() {
@Override
public boolean shouldOverrideUrlLoading(WebView view, String url) {
CustomTabsIntent.Builder builder = new CustomTabsIntent.Builder();
CustomTabsIntent customTabsIntent = builder.build();
customTabsIntent.launchUrl(WebViewActivity.this, Uri.parse(url));
return true;
}
});
return true;
}
@Override
public void onPermissionRequest(PermissionRequest request) {
List<String> permissionsToGrant = new ArrayList<>();
Expand Down