Skip to content

Conversation

@heiyu-04
Copy link

Correct the region detection logic

@luigoalma
Copy link
Contributor

Not sure if it's the best idea to classify C as the main source of information.
This given that C is also going to be also influencing serial number and is usually unsigned.
In all normal conditions, it will just have a different region.
In weird conditions (usually by user error or trying to follow weird guides) the serial information can also change.
This would make C as the main letter provided sys and would influence other scripts.
In my opinion, letter reported should be the originally found secinfo letter, that is not C.
Instead, report if C exists and what's the spoofed region on two other arguments, maybe even a third for spoofed S/N if you want to add that information, if for whatever reason that is the case.

@heiyu-04
Copy link
Author

Previously, I translated my GM9 script into a Lua script, but there was an issue with this part. If the user's device uses Godmod9 for ctrttransfer across regions (which creates a C file), but the script only reads the A file, it will result in region retrieval errors. In the previous GM9 script, I have seen a similar operation of retrieving A from C. If necessary, I will upload some test pictures in a few days.

@luigoalma
Copy link
Contributor

I understand that, however my opinion still stands on regards to C.
sys could provide instead region as the effective region (from C, or A or B if there's no C) as one variable and another as real region from non C.
To me, main letter of secinfo should still be the real secinfo's letter and then another variable to confirm C as existent.
A change in behavior can affect existing scripts as well, this could also lead to unattended side effects to some others.
So new variables with more information sounds better than changing current ones, this still would allow scripts to change around an addition rather than a change on a main behavior.
Up to someone to review this further and give their opinion too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants