Skip to content

Add Enums + Remove incomplete currency constants #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Code0x58 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Enums + Remove incomplete currency constants #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ed3050
Add Enums
Code0x58 Sep 14, 2021
580f1b0
Use constants and enums in message.py
Code0x58 Sep 14, 2021
ac9a870
Allow use of enums as tag/value
Code0x58 Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions simplefix/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,8 @@
########################################################################

"""FIX protocol constants."""

import sys


if sys.version_info[0] == 2:
EQUALS_BYTE = b'='
SOH_BYTE = b'\x01'
Expand Down Expand Up @@ -94,16 +92,7 @@

# Tag 15
TAG_CURRENCY = b'15'
CURRENCY_AFGHANI = b'AFA'
CURRENCY_ALGERIAN_DINAR = b'DZD'
CURRENCY_ANDORRAN_PESETA = b'ADP'
CURRENCY_ARGENTINE_PESO = b'ARS'
CURRENCY_ARMENIAN_DRAM = b'AMD'
CURRENCY_ARUBAN_GUILDER = b'AWG'
CURRENCY_AUSTRALIAN_DOLLAR = b'AUD'
CURRENCY_AZERBAIJANIAN_MANAT = b'AZM'
CURRENCY_BAHAMIAN_DOLLAR = b'BSD'
# FIXME: many, many, more.
# omitting the currencies as they are probably better to take as strings

# Tag 16
TAG_ENDSEQNO = b'16'
Expand Down Expand Up @@ -216,7 +205,7 @@

# Tag 25
TAG_IOIQLTYIND = b'25'
# this is to avoid breaking code using the old typo
# this is to avoid breaking code using the old typo, but should be removed in the next major version
TAG_IOIQlTYIND = TAG_IOIQLTYIND
IOIQLTYIND_HIGH = b'H'
IOIQLTYIND_MEDIUM = b'M'
Expand Down
Loading