Skip to content

Implement rank internals for the hospital-resident assignment problem #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daffidwilde merged 27 commits into from
May 15, 2025
Merged

Implement rank internals for the hospital-resident assignment problem #177

daffidwilde merged 27 commits into from
May 15, 2025

Conversation

@daffidwilde
Copy link
Owner

@daffidwilde daffidwilde commented Oct 25, 2024 •
edited
Loading

Make the move to rank internals for the HR game.

These are the big steps to come:

  • point SA at the old/current HR implementation
  • rebuild the HospitalResident class and tests
  • migrate algorithms into class (and their tests)
  • update documentation

I'll save the matching stability and validity checks for another PR; still deciding how best to implement that...

daffidwilde and others added 27 commits October 24, 2024 16:43
@daffidwilde
Move common test strategies out to top-level
ad2faa0
@daffidwilde
Write tests for HR init
23859e7
@daffidwilde
Move existing code around to avoid mass failure
7424a84
@daffidwilde
Write tests for alt HR instantiations
fb03f9d
@daffidwilde
Implement instantiation
cfc0866
@daffidwilde
Point HR example at the old version in README
730a468
@daffidwilde @henrywilde-cs
Move to uv (#178)
66a5ca4 
* Set up `uv` files and update workflows

* Fix typo in test runner step

* Format everything; replace `np.infty` w/ `np.inf`

---------

Co-authored-by: Henry Wilde <henry.wilde@creditsafe.com>
@henrywilde-cs
Merge branch 'dev-2.0.0' into rank-hr
f4530ca
@henrywilde-cs
Clean up README
34748c0
@henrywilde-cs
Close out example tests (temporarily)
4d79cf4
@henrywilde-cs
Make a stab at the HR algorithm; break matchings!
7c0fbec
@daffidwilde
Write algorithm tests
74b50ac
@daffidwilde
Write tests for HR solver
2b0c493
@daffidwilde
Shuffle method order in game classes
8e9617f
@daffidwilde
Write preference matching converter test; clean up
f8a095c
@daffidwilde
Ensure we catch warnings in existing tests
17caee8
@daffidwilde
Write tests for input validator
e1255b8
@daffidwilde
Implement input validator
492922d
@daffidwilde
Update HR tutorial
5470a71
@daffidwilde
Clean up from preferences method
842c910
@daffidwilde
Fix README examples
27b640d
@daffidwilde
Update all tutorials and the docs dependencies
17d4a47
@daffidwilde
Update how-tos and CI workflow
648cefd
@daffidwilde
Reach 100% coverage on HR components
8de017d
@daffidwilde
Write tests for the matching classes
04879b6
@daffidwilde
Get to 100% coverage on SM tests
8a31275
@daffidwilde
Enable branch coverage
ff6061e
@daffidwilde
Copy link
Owner Author

daffidwilde commented May 15, 2025

I am aware the tests are not passing, but the ones we care about are. So, I'm merging. We will catch the other tests down the line.

@daffidwilde daffidwilde merged commit 42b3da7 into rank-internals May 15, 2025
0 of 8 checks passed
@daffidwilde daffidwilde deleted the rank-hr branch May 15, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daffidwilde @henrywilde-cs